Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QnA files are sometimes added to project in the wrong place #4378

Closed
benbrown opened this issue Oct 14, 2020 · 4 comments · Fixed by #4612
Closed

QnA files are sometimes added to project in the wrong place #4378

benbrown opened this issue Oct 14, 2020 · 4 comments · Fixed by #4612
Assignees
Labels
P1 Painful if we don't fix, won't block releasing Team: Authoring Type: Bug Something isn't working
Milestone

Comments

@benbrown
Copy link
Contributor

Describe the bug

When a project is opened, for each dialog that DOES NOT ALREADY include a .qna file, one is added. However, these files are always added at the /dialogs/nameOfDialog folder.

If the dialogs in question are not in the /dialogs folder, or are in a subfolder of the dialogs folder, the related .qna files should be placed in the existing folder, not in a new one.

For example, if /dialogs/imported/getEmail is added to the project, the .qna file should be in /dialogs/imported/getEmail, not in /dialogs/getEmail as currently happens, resulting in 2 folders.

Whatever code is creating these .qna files should NOT be opinionated about the location of the dialogs, as they can technically exist in any folder or subfolder of the project.

Version

1.1.1

Steps to reproduce the behavior:

  1. Create a project
  2. Open it in the file system and copy an existing dialog into /dialogs/imported/someFolderName
  3. Open the project in Composer
  4. Look at the file system again - you will see /dialogs/someFolderName has been erroneously created with an empty qna file.

Expected behavior

The new qna file will be created inside the existing folder.

@benbrown benbrown added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Oct 14, 2020
@srinaath
Copy link
Contributor

@liweitian  i remember u writing the piece for migration on the Composer server. Seems like the .qna files are getting created at the wrong path

@cwhitten cwhitten added Team: Authoring and removed Needs-triage A new issue that require triage labels Oct 15, 2020
@cwhitten cwhitten added this to the R11 milestone Oct 15, 2020
@cwhitten
Copy link
Member

@liweitian @zhixzhan I've added this into R11 as something we want to address before our next release.

@cwhitten cwhitten added the P1 Painful if we don't fix, won't block releasing label Oct 15, 2020
@liweitian
Copy link
Contributor

@cwhitten will have a look.

@zhixzhan
Copy link
Contributor

zhixzhan commented Nov 2, 2020

I'm looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Painful if we don't fix, won't block releasing Team: Authoring Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants