Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to support LU intent copy / delete / move #2273

Closed
hibrenda opened this issue Mar 16, 2020 · 4 comments
Closed

Need to support LU intent copy / delete / move #2273

hibrenda opened this issue Mar 16, 2020 · 4 comments
Assignees
Labels
P0 Must Fix. Release-blocker R9 Release 9 - May 15th, 2020 Type: Bug Something isn't working

Comments

@hibrenda
Copy link
Contributor

  • select one node or several nodes (inputs with user utterance)
  • copy and paste in the dialog, no lu intent copied
  • move to the new dialog, no lu content copied
@hibrenda hibrenda added the Type: Bug Something isn't working label Mar 16, 2020
@hibrenda hibrenda added the R9 Release 9 - May 15th, 2020 label Mar 17, 2020
@yeze322 yeze322 added the P2 Nice to have label Mar 19, 2020
@cwhitten cwhitten added P0 Must Fix. Release-blocker and removed P2 Nice to have labels Apr 3, 2020
@cwhitten
Copy link
Member

cwhitten commented Apr 3, 2020

Before implementation we need to check-in with @vishwacsena's opinion on giving users the option to copy lu data as a reference/import or a total clone of the data into new dialog's lu file. I believe we should give this option when copying lu data across dialogs.

@yeze322
Copy link
Contributor

yeze322 commented Apr 3, 2020

As I discussed with Chris, the LU copy work will be postponed.
Instead, I will focus on a refactoring PR to move the copy hebavior from Visual Editor to Shell and make it a shared logic across Visual/Form/Shell. Then we can have the flexibility to let users choose whether they need to carry LU data during copy.

@yeze322
Copy link
Contributor

yeze322 commented Apr 8, 2020

We had a decision that

it is fine and intended to do a deep-copy of LU data for now

The recommendation is to deep copy from the flow operations, but allow direct file modifications from the all-up views

So if a user wanted to change it to a reference across dialogs or triggers, they can do that

(quote Chris)

@yeze322 yeze322 changed the title Need to support lu intent copy for nodes and across dialog move Need to support LU intent copy / delete / move Apr 14, 2020
@cwhitten
Copy link
Member

#2718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must Fix. Release-blocker R9 Release 9 - May 15th, 2020 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants