resolves review comments

Author: grobyns

src/Business Foundation/App/NoSeries/src/Upgrade/NoSeriesInstaller.Codeunit.al

@@ -15,7 +15,7 @@ codeunit 329 "No. Series Installer"
 
     trigger OnInstallAppPerCompany()
     begin
-        TriggerMovedTableSchemaCheck();
+        TriggerMovedTableSchemaSanityCheck();
         SetupNoSeriesImplementation();
     end;
 
@@ -36,7 +36,14 @@ codeunit 329 "No. Series Installer"
         UpgradeTag.SetUpgradeTag(NoSeriesUpgradeTags.GetImplementationUpgradeTag());
     end;
 
-    local procedure TriggerMovedTableSchemaCheck()
+    /// <summary>
+    /// This method is used to ensure that the runtime metadata matches the schema for moved tables.
+    /// </summary>
+    /// <remarks>
+    /// The if .. then statements ensure the code does not fail when the tables are empty. The presence of data is not important, the FindFirst will trigger a schema check.
+    /// Should this code fail it would indicate a bug in the server code. The code is not expected to fail.
+    /// </remarks>
+    internal procedure TriggerMovedTableSchemaSanityCheck()
     var
         NoSeries: Record "No. Series";
         NoSeriesLine: Record "No. Series Line";
@@ -46,7 +53,12 @@ codeunit 329 "No. Series Installer"
         NoSeriesLineSales: Record "No. Series Line Sales";
         NoSeriesLinePurchase: Record "No. Series Line Purchase";
 #endif
+        UpgradeTag: Codeunit "Upgrade Tag";
+        NoSeriesUpgradeTags: Codeunit "No. Series Upgrade Tags";
     begin
+        if UpgradeTag.HasUpgradeTag(NoSeriesUpgradeTags.GetMovedTableSchemaSanityCheckUpgradeTag()) then
+            exit;
+
 #pragma warning disable AA0175
         if NoSeries.FindFirst() then;
         if NoSeriesLine.FindFirst() then;
@@ -57,5 +69,7 @@ codeunit 329 "No. Series Installer"
         if NoSeriesLinePurchase.FindFirst() then;
 #endif
 #pragma warning restore AA0175
+
+        UpgradeTag.SetUpgradeTag(NoSeriesUpgradeTags.GetMovedTableSchemaSanityCheckUpgradeTag());
     end;
 }

src/Business Foundation/App/NoSeries/src/Upgrade/NoSeriesUpgrade.Codeunit.al

@@ -0,0 +1,18 @@
+// ------------------------------------------------------------------------------------------------
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+// ------------------------------------------------------------------------------------------------
+
+namespace Microsoft.Foundation.NoSeries;
+codeunit 328 "No. Series Upgrade"
+{
+    Access = Internal;
+    Subtype = Upgrade;
+
+    trigger OnUpgradePerCompany()
+    var
+        NoSeriesInstaller: Codeunit "No. Series Installer";
+    begin
+        NoSeriesInstaller.TriggerMovedTableSchemaSanityCheck();
+    end;
+}

src/Business Foundation/App/NoSeries/src/Upgrade/NoSeriesUpgradeTags.Codeunit.al

@@ -15,4 +15,9 @@ codeunit 332 "No. Series Upgrade Tags"
     begin
         exit('MS-471519-AddImplementationExtensibility-20231206 ');
     end;
+
+    procedure GetMovedTableSchemaSanityCheckUpgradeTag(): Code[250]
+    begin
+        exit('MS-523755-AddMovedTableSchemaSanityCheck-20240402');
+    end;
 }