Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OHDSI workspace service #3562

Merged
merged 21 commits into from
Jun 26, 2023
Merged

Add OHDSI workspace service #3562

merged 21 commits into from
Jun 26, 2023

Conversation

yuvalyaron
Copy link
Collaborator

Resolves #1505

What is being addressed

Added OHDSI workspace service

How is this addressed

  • Currently supports Synapse only.
  • The workspace service will not function out of the box. In order for it to work, additional networking must be done to establish a connection with a data source. Further details are provided in the README.md file.

yuvalyaron and others added 4 commits June 7, 2023 08:27
* remove todos

* link core vnet to postgres private dns zone when deploying core

* remove synapse references, and add other data sources to the options

* remove postgres_core_dns_link references

* revert synapse reference deletions

* remove non supported dialects

* add execute permission to scripts

* make some of the daimons required

* add required zone field to postgres:
hashicorp/terraform-provider-azurerm#16888

* add fw rule to allow open id authentication in atlas

* fix firewall step

* add README

* update README

* fix linting errors

* fix linting errors
@github-actions
Copy link

github-actions bot commented Jun 11, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 5ff4e5b.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron marked this pull request as ready for review June 11, 2023 15:04
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few docs related comments.

Is there a way I can test this out? What can I do about data? Can we add details to the docs?

templates/workspace_services/ohdsi/README.md Show resolved Hide resolved
templates/workspace_services/ohdsi/README.md Outdated Show resolved Hide resolved
templates/workspace_services/ohdsi/README.md Outdated Show resolved Hide resolved
templates/workspace_services/ohdsi/README.md Outdated Show resolved Hide resolved
@yuvalyaron yuvalyaron requested a review from marrobi June 12, 2023 14:31
@marrobi marrobi dismissed their stale review June 26, 2023 15:17

Happy with docs update.

@yuvalyaron yuvalyaron enabled auto-merge (squash) June 26, 2023 15:19
@yuvalyaron
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5380031116 (with refid 7a85ea5e)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 8c82fd7 into main Jun 26, 2023
@yuvalyaron yuvalyaron deleted the feature/ohdsi branch June 26, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OHDSI Atlas Workspace Service
3 participants