Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Nexus bundle to use KeyVault VM Extension #3453

Merged
merged 5 commits into from
Apr 23, 2023

Conversation

tamirkamara
Copy link
Collaborator

Resolves #3451

What is being addressed

A prior PR removed some firewall rules that are needed for az login that is used in the Nexus bundle to configure its ssl.

How is this addressed

  • Refactor the bundle to use KeyVault VM extension to fetch the certificate and remove the need for az-cli.
  • Upgrade versions in the firewall and nexus bundles.

@github-actions
Copy link

github-actions bot commented Apr 23, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ff1f26e.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4777148020 (with refid dbc3782e)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-shared-services

@tamirkamara tamirkamara enabled auto-merge (squash) April 23, 2023 07:53
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running shared service tests: https://github.com/microsoft/AzureTRE/actions/runs/4777176615 (with refid dbc3782e)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-shared-services

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running shared service tests: https://github.com/microsoft/AzureTRE/actions/runs/4777978174 (with refid dbc3782e)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit da061f8 into main Apr 23, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3451-nexus-certs branch April 23, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nexus install fails as az cli needs access to login.microsoftonline.com
2 participants