Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret properties of workspace are no longer being redacted #2836

Closed
tanya-borisova opened this issue Nov 8, 2022 · 0 comments · Fixed by #2873
Closed

Secret properties of workspace are no longer being redacted #2836

tanya-borisova opened this issue Nov 8, 2022 · 0 comments · Fixed by #2873
Assignees
@damoodamoo
Labels
bug Something isn't working

Comments

@tanya-borisova
Copy link
Contributor

tanya-borisova commented Nov 8, 2022 •
edited
Loading

Remember to label the issue with the appropriate area, and also assign it to yourself if you plan to work on the issue in the near future.

Describe the bug

Properties of workspace such as client_secret are no longer being redacted.

This is due to the fact that they used to be under "properties" field, but are no longer there as per #2805 , and are instead on a level above.

The secret redaction code should be changed to account for this fact, and the test should be updated too.

Steps to reproduce

  1. Deploy a workspace with client_secret set
  2. Secret does not show "REDACTED" on the UI:

image
@tanya-borisova tanya-borisova added the bug Something isn't working label Nov 8, 2022
@damoodamoo damoodamoo self-assigned this Nov 9, 2022
This was referenced Nov 9, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damoodamoo damoodamoo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@damoodamoo @tanya-borisova