Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NexusV2 & Certs configures firewall with deployment pipeline #2328

Closed
3 tasks
tamirkamara opened this issue Jul 24, 2022 · 1 comment · Fixed by #3089
Closed
3 tasks

NexusV2 & Certs configures firewall with deployment pipeline #2328

tamirkamara opened this issue Jul 24, 2022 · 1 comment · Fixed by #3089
Labels
bundles Creating and deploying bundles/templates story Stories are the smallest unit of work to be done for a project.

Comments

@tamirkamara
Copy link
Collaborator

Description

As a TRE Developer
I want to configure required firewall rules with the deployment pipeline
So that firewall rules will be managed centrally in the shared service

Acceptance criteria

  • Hardcoded rules are removed from Terraform files
  • Required rules are present in firewall on azure and in state of the firewall shared service
  • Both install and uninstall work
@tamirkamara tamirkamara added bundles Creating and deploying bundles/templates story Stories are the smallest unit of work to be done for a project. labels Jul 24, 2022
@marrobi marrobi added this to the Release 0.5 milestone Jul 27, 2022
@tamirkamara tamirkamara changed the title NexusV2 & Certs configures firewall with deployment pipeline bundles story NexusV2 & Certs configures firewall with deployment pipeline Jul 31, 2022
@tamirkamara
Copy link
Collaborator Author

Challenges in doing this:

  1. Certs currently needs the firewall rule while running TF as it calls on letsencrypt in the main step so having the pipeline execute the firewall update after the main TF runs isn't easy. I've thought of the following approach: run the TF (without firewall / letsencrypt), pipeline add the fw rules, pipeline calls the primary bundle again with the renew action as that does the same as from within the TF definition. UNKOWN if we can call the primary bundle twice (initial tests caused weird errors).
  2. Nexus - while TF creates the VM it also puts user data (scripts) that requires firewall rules that are only created later in the pipeline way. A possible way to forward would be moving to a custom script extension but need to find a way to execute it (similar to the certs, we need to call the primary bundle twice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundles Creating and deploying bundles/templates story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants