Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update general onboarding instructions after upgrading to Servlet 3.0 #596

Closed
littleaj opened this issue Mar 7, 2018 · 3 comments
Closed
Milestone

Comments

@littleaj
Copy link
Contributor

littleaj commented Mar 7, 2018

Now, the filter definition in web.xml is not necessary from the changes in #568 (unless the metadata-complete=true attribute is specified).

The instructions should include how include the filter/listener automatically as well as manually via web.xml.

It should be stated that the listener is now a necessity.

@littleaj littleaj added this to the 2.0.2 milestone Mar 7, 2018
@littleaj littleaj modified the milestones: 2.0.2, 2.1.3 Jun 15, 2018
@dhaval24
Copy link
Contributor

dhaval24 commented Aug 13, 2018

@littleaj / @nikmd23 did we ever updated this after you added the annotations? If not is it possible for you to find a time slot and get this done?

@nikmd23
Copy link
Member

nikmd23 commented Aug 31, 2018

I'm not quite sure where this stands given @dhaval24's comment.

@littleaj, could you add a bit of clarity around if docs changes are in fact required, and if so what those changes are.

@dhaval24 dhaval24 modified the milestones: 2.1.3, future Sep 25, 2018
@littleaj
Copy link
Contributor Author

littleaj commented Oct 1, 2018

This was reverted. We are not using the Servlet 3 annotations anymore as they caused issues in the field and actually made the filter less flexible.

@littleaj littleaj closed this as completed Oct 1, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants