Add applicationinsights-rp.json #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
reviewed
Mar 15, 2021
...soft/applicationinsights/agent/internal/wasbootstrap/configuration/ConfigurationBuilder.java
Show resolved
Hide resolved
...soft/applicationinsights/agent/internal/wasbootstrap/configuration/ConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
...soft/applicationinsights/agent/internal/wasbootstrap/configuration/ConfigurationBuilder.java
Show resolved
Hide resolved
...ft/applicationinsights/agent/internal/wasbootstrap/configuration/RpConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/com/microsoft/applicationinsights/agent/internal/RpConfigurationPolling.java
Show resolved
Hide resolved
heyams
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move configuration needed by Azure Spring Cloud into separate json file, to make it explicit that these are the only configuration options we support for RP, and to make it clear the RP config in this file always takes precedence.
Also so that we can implement not reading
applicationinsights.jsonfrom agent directory for rp integrations in #1558 because reading that makes it difficult to merge applicationinsights.json from RP and user json fromAPPLICATIONINSIGHTS_CONFIGURATION_CONTENT