Collect perf counters using Oshi #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Feb 9, 2021
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Feb 10, 2021
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/internal/perfcounter/OshiPerformanceCounter.java
Outdated
Show resolved
Hide resolved
…ch might end up negative values
trask
reviewed
Feb 10, 2021
trask
reviewed
Feb 16, 2021
There was a problem hiding this comment.
@heyams a couple of things
- "\Processor(_Total)\% Processor Time" doesn't match between the new and old way for me
- Let's capture IO and Processor Total at startup, so that the first reporting of data can report the diff already
- I'm getting this during startup:
2021-02-16 11:26:45.277-08 ERROR o.s.o.windows.WindowsOperatingSystem - AdjustTokenPrivileges failed. Error: 1300
trask
force-pushed
the
heya/oshi
branch
2 times, most recently
from
202de0a
to
72739cf
Compare
trask
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will convert the rest on a separate PR.