Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry transmission on client side exception #1282

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

trask
Copy link
Member

@trask trask commented Jul 15, 2020

Fixes an issue where read timeout (and other networking related exceptions) are not retried, e.g.

AI: ERROR 09-07-2020 06:02:52.258+0000, 547(ActiveTransmissionNetworkOutput_1-4): Failed to send.
Stack Trace:
java.net.SocketTimeoutException: Read timed out
        at java.net.SocketInputStream.socketRead0(Native Method)
        at java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
        at java.net.SocketInputStream.read(SocketInputStream.java:171)
        at java.net.SocketInputStream.read(SocketInputStream.java:141)
        at sun.security.ssl.InputRecord.readFully(InputRecord.java:465)
        at sun.security.ssl.InputRecord.read(InputRecord.java:503)
        at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:975)
        at sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:933)
        at sun.security.ssl.AppInputStream.read(AppInputStream.java:105)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:137)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.io.SessionInputBufferImpl.fillBuffer(SessionInputBufferImpl.java:153)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.io.SessionInputBufferImpl.readLine(SessionInputBufferImpl.java:282)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:138)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:165)
        at com.microsoft.applicationinsights.core.dependencies.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)
        at com.microsoft.applicationinsights.core.dependencies.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
        at com.microsoft.applicationinsights.core.dependencies.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
        at com.microsoft.applicationinsights.internal.channel.common.ApacheSender43.sendPostRequest(ApacheSender43.java:82)
        at com.microsoft.applicationinsights.internal.channel.common.TransmissionNetworkOutput.send(TransmissionNetworkOutput.java:176)
        at com.microsoft.applicationinsights.internal.channel.common.ActiveTransmissionNetworkOutput$1.run(ActiveTransmissionNetworkOutput.java:79)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)

AI: TRACE 09-07-2020 06:02:52.259+0000, 547(ActiveTransmissionNetworkOutput_1-4): Http response code 0 not handled by com.microsoft.applicationinsights.internal.channel.common.ErrorHandler
AI: TRACE 09-07-2020 06:02:52.259+0000, 547(ActiveTransmissionNetworkOutput_1-4): Http response code 0 not handled by com.microsoft.applicationinsights.internal.channel.common.PartialSuccessHandler
AI: TRACE 09-07-2020 06:02:52.259+0000, 547(ActiveTransmissionNetworkOutput_1-4): Http response code 0 not handled by com.microsoft.applicationinsights.internal.channel.common.ThrottlingHandler.

@trask trask requested a review from littleaj July 15, 2020 20:20
@trask trask merged commit 95de34b into master Jul 15, 2020
@trask trask deleted the trask/retry-transmission branch July 15, 2020 23:41
@maysmiling
Copy link

We see the same error in version Application Insights Java 3.0 Preview.4. Does the version Application Insights Java 3.0 Preview.5 have the same issue? By the way, what is the difference between Application Insights Java 3.0 Preview.5 and Application Insights Java SDK 2.6.2-BETA.2? They contains different jar files. What are they used for seperately?

@trask
Copy link
Member Author

trask commented Nov 17, 2020

This fix was merged into Java 3.0 Preview 7 (and now also in 3.0 GA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants