Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning if trace message exceeds Sanitizer.MAX_MESSAGE_LENGTH #1021

Closed
Dpetters opened this issue Aug 15, 2019 · 1 comment · Fixed by #1811
Closed

Log warning if trace message exceeds Sanitizer.MAX_MESSAGE_LENGTH #1021

Dpetters opened this issue Aug 15, 2019 · 1 comment · Fixed by #1811
Assignees
Milestone

Comments

@Dpetters
Copy link

Dpetters commented Aug 15, 2019

Is your feature request related to a problem? Please describe.
I spent too much time debugging why we had an odd drop in a metric in a PowerBI dashboard that we power with our AI telemetry. The root cause ended up being some trace messages getting silently truncated.

Describe the solution you would like
Enabling SDKLogger should cause some warnings to be printed out in the cases where the messages exceed Sanitizer.MAX_MESSAGE_LENGTH.

Describe alternatives you have considered
n/a

Additional context
n/a

@littleaj littleaj self-assigned this Aug 21, 2019
@trask trask added this to the future milestone Jun 10, 2020
@trask trask modified the milestones: future, 3.2.0-BETA.2 Jul 23, 2021
@ghost ghost added the Status: Fixed label Jul 23, 2021
@trask
Copy link
Member

trask commented Aug 4, 2021

this is addressed now in 3.2.0-BETA.2

@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants