Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][Custom Action] [ Can not send additional properties to action delegates in case of custom action] #5025

Closed
1 task
jyoti-ms opened this issue Nov 3, 2020 · 5 comments · Fixed by #5008
Closed
1 task

[iOS][Custom Action] [ Can not send additional properties to action delegates in case of custom action] #5025

jyoti-ms opened this issue Nov 3, 2020 · 5 comments · Fixed by #5008
Assignees
@jwoo-msft
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Platform-iOS
Milestone
20.11-12

Comments

@jyoti-ms
Copy link

jyoti-ms commented Nov 3, 2020

Platform

What platform is your issue or question related to? (Delete other platforms).

  • iOS

Author or host

Teams

Version of SDK

2.3.0

Details

Currently we can not build target with action element. It would be good to have build target function for BaseActionElement so that we can send extra properties in case of custom action to the delegate function.
@jyoti-ms jyoti-ms added the Bug label Nov 3, 2020
@ghost ghost added the Triage-Needed label Nov 3, 2020
@ghost ghost added this to the 20.11 milestone Nov 3, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@ghost ghost added the High Priority label Nov 3, 2020
@ghost ghost removed the Triage-Needed label Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

Hi @jyoti-ms. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@shalinijoshi19
Copy link
Member

@jwoo-msft this one lower/normal priority to be tackled later - Are you able to articulate the workaround here pls? Thanks!

@jwoo-msft jwoo-msft mentioned this issue Nov 4, 2020
Merged
@ghost ghost added the Status-In Code Review label Nov 4, 2020
@ghost
Copy link

ghost commented Nov 5, 2020

🎉AdaptiveCards@2020.10.1 has been released which fixes this issue.:tada:

Handy links:

@ghost ghost added the AdaptiveCards v20.11 label Nov 5, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

🎉AdaptiveCards@2020.12 has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwoo-msft jwoo-msft

Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Platform-iOS
Projects
None yet
Milestone
20.11-12
Development

Successfully merging a pull request may close this issue.

Updated Target Builder Director Interface microsoft/AdaptiveCards
3 participants
@jwoo-msft @shalinijoshi19 @jyoti-ms