Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Column Rendering] Long column content shrinks auto/fixed sized columns #4988

Closed
1 task
almedina-ms opened this issue Oct 29, 2020 · 3 comments · Fixed by #5084
Closed
1 task
Assignees
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Milestone

Comments

@almedina-ms
Copy link
Contributor

almedina-ms commented Oct 29, 2020

Platform

What platform is your issue or question related to? (Delete other platforms).

  • Android

Version of SDK

main

Details

Refer to Teams' surveyMonkey.txt and imageOverlap.txt payloads. The column with survey icon shrinks due to the long text on the right column.

Screenshot of imageOverlap.txt on 2.1.0 vs 2.3.1:

image

In Agenda.json scenario card the column content is pushing the PowerPoint logo column so much that it's not appearing

image

the card is rendered correctly in Javascript

image

Another example:

Android:
Screenshot 2020-07-31 at 3 30 01 PM
Desktop:
Screenshot 2020-07-31 at 3 29 48 PM

ACColumnSetImageWidth.txt

{
  "type": "AdaptiveCard",
  "body": [
    {
      "type": "ColumnSet",
      "columns": [
        {
          "type": "Column",
          "items": [
            {
              "type": "TextBlock",
              "size": "ExtraLarge",
              "weight": "Lighter",
              "text": "BLR"
            }
          ],
          "width": "auto"
        },
        {
          "type": "Column",
          "verticalContentAlignment": "Center",
          "items": [
            {
              "type": "Image",
              "url": "https://messagecardplayground.azurewebsites.net/assets/graydot2x2.png",
              "width": "10000px",
              "height": "2px"
            }
          ],
          "width": "stretch"
        },
        {
          "type": "Column",
          "spacing": "Small",
          "verticalContentAlignment": "Center",
          "items": [
            {
              "type": "Image",
              "url": "https://messagecardplayground.azurewebsites.net/assets/smallairplane.png",
              "height": "16px",
              "altText": "Flight to"
            }
          ],
          "width": "auto"
        },
        {
          "type": "Column",
          "items": [
            {
              "type": "TextBlock",
              "horizontalAlignment": "Right",
              "size": "ExtraLarge",
              "weight": "Lighter",
              "text": "CDG"
            }
          ],
          "width": "auto"
        }
      ],
      "height": "stretch"
    }
  ],
  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
  "version": "1.0"
}
@ghost ghost added this to the 20.11 milestone Oct 29, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Oct 29, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@almedina-ms almedina-ms changed the title [Platform][Broad Issue Category if applicable (eg Accessibility)] [Bug Title] [Android][Column Rendering] Long text makes column with image not show up at all Oct 29, 2020
@shalinijoshi19
Copy link
Member

@almedina-ms is this a ship blocker for 20.10? @RebeccaAnne FYI

@ghost ghost added the AdaptiveCards v20.11 label Nov 5, 2020
@golddove golddove changed the title [Android][Column Rendering] Long text makes column with image not show up at all [Android][Column Rendering] Long column content shrinks auto/fixed sized columns Nov 6, 2020
@shalinijoshi19 shalinijoshi19 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Triage-Investigate and removed Triage-Approved for Fix High Priority labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants