Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptive Card Designer - toolbar buttons missing html type attribute #4721

Closed
bzbetty opened this issue Sep 1, 2020 · 4 comments · Fixed by #4784
Closed

Adaptive Card Designer - toolbar buttons missing html type attribute #4721

bzbetty opened this issue Sep 1, 2020 · 4 comments · Fixed by #4784
Assignees
@golddove
Labels
Area-Designer Bug Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios
Milestone
20.09

Comments

@bzbetty
Copy link

bzbetty commented Sep 1, 2020

Similar to microsoft/BotFramework-WebChat#594, the buttons in the adaptive card designer are missing the type="button" attribute which means if it's embedded in a html form tag it tries to submit the form anytime buttons like the "new card" button is pushed.
@bzbetty bzbetty added the Bug label Sep 1, 2020
@ghost ghost added the Triage-Needed label Sep 1, 2020
@shalinijoshi19
Copy link
Member

@dclaux are you able to take a look at this please? Thanks

@shalinijoshi19 shalinijoshi19 added this to the 20.09 milestone Sep 4, 2020
@ghost ghost removed the Triage-Needed label Sep 4, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

Hi @bzbetty. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@ghost ghost added the Triage-Investigate label Sep 4, 2020
@golddove golddove mentioned this issue Sep 18, 2020
Merged
@shalinijoshi19
Copy link
Member

@golddove is this for Cisco by anychance? If so can you take it with the Cisco label? thanks

@shalinijoshi19 shalinijoshi19 removed this from the 20.09 milestone Sep 21, 2020
@ghost ghost added the AdaptiveCards v20.09 label Sep 21, 2020
@shalinijoshi19 shalinijoshi19 added this to the 20.09 milestone Sep 21, 2020
@shalinijoshi19 shalinijoshi19 added the Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios label Sep 27, 2020
@golddove golddove assigned golddove and unassigned dclaux Sep 28, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

🎉AdaptiveCards@2020.09 has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@golddove golddove

Labels
Area-Designer Bug Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios
Projects
None yet
Milestone
20.09
Development

Successfully merging a pull request may close this issue.

[Designer] Toolbar button type=button microsoft/AdaptiveCards
4 participants
@bzbetty @dclaux @golddove @shalinijoshi19