Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS][Templating] "$when" should not be emitted in expanded template #4692

Closed
dclaux opened this issue Aug 28, 2020 · 1 comment · Fixed by #4693
Closed

[JS][Templating] "$when" should not be emitted in expanded template #4692

dclaux opened this issue Aug 28, 2020 · 1 comment · Fixed by #4693
Labels
Milestone

Comments

@dclaux
Copy link
Member

dclaux commented Aug 28, 2020

Platform

  • JavaScript

Details

The $when clause is correctly handled by the templating engine, but when it evaluates to true it is emitted into the generated payload.

Example:

{
  "type": "AdaptiveCard",
  "$data": {
    "isVisible": true
  },
  "body": [
    {
        "type": "TextBlock",
        "$when": "${isVisible}",
        "text": "Hello world"
    }
  ]
}

After expansion, the generated payload is:

{
  "type": "AdaptiveCard",
  "body": [
    {
        "type": "TextBlock",
        "$when": true,
        "text": "Hello world"
    }
  ]
}

While the presence of the $when property doesn't hurt, it jus shouldn't be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants