-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inconsistency] Parse failures for a given property should not fail the entire card #4565
Closed
9 of 29 tasks
Labels
Milestone
Comments
RebeccaAnne
added
Bug
Area-Inconsistency
Bugs around renderer inconsistencies across different platforms
labels
Aug 10, 2020
ghost
added
the
Triage-Needed
label
Aug 10, 2020
Hi @RebeccaAnne. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions. |
@jwoo-msft something to look into driving once you are back as part of the Inconsistency workstream! Thanks |
@jwoo-msft what's the POA on this one? |
ghost
removed
the
AdaptiveCards v20.09
label
Sep 21, 2020
This was referenced Sep 28, 2020
ghost
added
the
AdaptiveCards v20.11
label
Nov 5, 2020
ghost
removed
the
AdaptiveCards v20.11
label
Nov 20, 2020
ghost
added
the
AdaptiveCards v20.11
label
Nov 23, 2020
ghost
removed
the
AdaptiveCards v20.11
label
Dec 1, 2020
ghost
added
the
AdaptiveCards v21.01
label
Dec 18, 2020
ghost
removed
the
AdaptiveCards v21.01
label
Jan 22, 2021
Tracking this work via Epic #6015 and it's corresponding sub tasks. |
ghost
removed
the
Triage-Approved for Fix
label
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Platform
What platform is your issue or question related to? (Delete other platforms).
.NET WPF and .NET HTML do need verification.
Details
Currently the shared model platforms fail parsing of the entire card in the case that there is a parse error in any property. JavaScript on the other hand, drops only the failing element, returning a warning and continuing to parse. This issue tracks updating all platforms to behave consistently with JavaScript.
Required Properties List
This is not extensive list and will grow eventually to include all required properties.
Shared Model
Logging
All parsers and renders should be able to log Parse Error when required properties are missing, and Renderer Warnings when encountered adaptive elements with missing required properties.
Parser Error
Render Warning
The text was updated successfully, but these errors were encountered: