Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inconsistency] Parse failures for a given property should not fail the entire card #4565

Closed
9 of 29 tasks
RebeccaAnne opened this issue Aug 10, 2020 · 4 comments
Closed
9 of 29 tasks
Assignees
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug
Milestone

Comments

@RebeccaAnne
Copy link
Contributor

RebeccaAnne commented Aug 10, 2020

Platform

What platform is your issue or question related to? (Delete other platforms).

  • .NET HTML
  • .NET WPF
  • Android
  • iOS
  • JavaScript
  • UWP
  • Validation

.NET WPF and .NET HTML do need verification.

  • Validating this task can be extensive, so added a task of developing validation procedure that can be used across the platforms.

Details

Currently the shared model platforms fail parsing of the entire card in the case that there is a parse error in any property. JavaScript on the other hand, drops only the failing element, returning a warning and continuing to parse. This issue tracks updating all platforms to behave consistently with JavaScript.

Required Properties List

This is not extensive list and will grow eventually to include all required properties.

Shared Model

Logging

All parsers and renders should be able to log Parse Error when required properties are missing, and Renderer Warnings when encountered adaptive elements with missing required properties.

Parser Error

  • .NET HTML
  • .NET WPF
  • Android
  • iOS
  • JavaScript
  • UWP

Render Warning

  • .NET HTML
  • .NET WPF
  • Android
  • iOS
  • JavaScript
  • UWP
@RebeccaAnne RebeccaAnne added Bug Area-Inconsistency Bugs around renderer inconsistencies across different platforms labels Aug 10, 2020
@RebeccaAnne RebeccaAnne added this to the 20.08 milestone Aug 10, 2020
@ghost ghost added the Triage-Needed label Aug 10, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

Hi @RebeccaAnne. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@shalinijoshi19
Copy link
Member

@jwoo-msft something to look into driving once you are back as part of the Inconsistency workstream! Thanks

@RebeccaAnne RebeccaAnne modified the milestones: 20.08, 20.09 Aug 24, 2020
@shalinijoshi19 shalinijoshi19 removed this from the 20.09 milestone Sep 21, 2020
@ghost ghost added the AdaptiveCards v20.09 label Sep 21, 2020
@shalinijoshi19 shalinijoshi19 added this to the 20.10 milestone Sep 21, 2020
@shalinijoshi19
Copy link
Member

@jwoo-msft what's the POA on this one?

@ghost ghost added the AdaptiveCards v20.11 label Nov 23, 2020
@jwoo-msft jwoo-msft modified the milestones: 20.11-12, 21.01 Nov 30, 2020
@ghost ghost removed the AdaptiveCards v20.11 label Dec 1, 2020
@ghost ghost added the AdaptiveCards v21.01 label Dec 18, 2020
@jwoo-msft jwoo-msft modified the milestones: 21.01, 21.02 Jan 21, 2021
@jwoo-msft jwoo-msft modified the milestones: 21.02, 21.03 Jan 21, 2021
@ghost ghost removed the AdaptiveCards v21.01 label Jan 22, 2021
@RebeccaAnne RebeccaAnne modified the milestones: 21.03, Short Term Apr 5, 2021
@jwoo-msft jwoo-msft modified the milestones: Short Term, 21.04 Apr 8, 2021
@RebeccaAnne
Copy link
Contributor Author

Tracking this work via Epic #6015 and it's corresponding sub tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug
Projects
None yet
Development

No branches or pull requests

3 participants