Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Image Rendering] - Rendered image inside card are down scaled via ResourceResolver #4410

Closed
ankbat opened this issue Jul 17, 2020 · 4 comments · Fixed by #4380
Closed
Assignees
Labels
Bug Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios

Comments

@ankbat
Copy link

ankbat commented Jul 17, 2020

Platform

  • Android

Version of SDK

1.2.6 (Maven repository)

Details

The images in some cards are not rendered in the expected size. The rendered images are down scaled from its original size in some of the cards. IResourceResolver is used and bitmap is getting returned on resolveImageResource function from the client.

Payload data : Restaurant Card

Screenshots

Android

Screenshot 2020-07-08 at 11 31 13 AM

Expected

Picture 1

@ankbat ankbat added the Bug label Jul 17, 2020
@ghost ghost added the Triage-Needed label Jul 17, 2020
@ghost
Copy link

ghost commented Jul 17, 2020

Hi @ankbat. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@shalinijoshi19 shalinijoshi19 added Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios AdaptiveCards v1.2.11 labels Jul 17, 2020
@shalinijoshi19
Copy link
Member

@golddove could you link this issue to the PRs wiht the resource resolver fix to close out..tx

@golddove
Copy link
Member

@ankbat even after our scaling fix on Android, please note that when size is set to "auto," the image should not scale up.

Refer to our schema docs on size: https://adaptivecards.io/explorer/Image.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants