Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data binding to boolean expression fails #4261

Closed
IntranetFactory opened this issue Jun 30, 2020 · 4 comments · Fixed by #4351
Closed

data binding to boolean expression fails #4261

IntranetFactory opened this issue Jun 30, 2020 · 4 comments · Fixed by #4351
Labels
Area-Templating Bug Platform-JavaScript Bugs or features related to the JavaScript renderer
Milestone
1.3 Schema Refresh

Comments

@IntranetFactory
Copy link

I need to bind isVisible to an expression returning a boolean.

When I use the expression "text": "n = ${count(records)}, visible ${count(records)>10}", and records[] contains 7 objects I get, as expected false for ${count(records)>10} :
image

But how can I now bind that to isVisible?

"isVisible": ${count(records)>10} is not valid json
"isVisible": "${count(records)>10}" seems to evaluate to true, at least the text is visible

image
@ghost ghost added the Triage-Needed label Jun 30, 2020
@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Jun 30, 2020 •
edited
Loading

@dclaux could you take a first pass? Cc: @jwoo-msft also here ..

@shalinijoshi19 shalinijoshi19 added Area-Templating Platform-JavaScript Bugs or features related to the JavaScript renderer labels Jun 30, 2020
@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Jul 10, 2020 •
edited
Loading

Hello @IntranetFactory we recently released an updated version of the designer package here https://www.npmjs.com/package/adaptivecards-designer as well as templating 1.0.0; Could you please retry and let us know if this works now for you? Thanks

@IntranetFactory
Copy link
Author

Problem still exists. I was even unable to bind any bool (see #4350) so I think problem is not only a boolean expression, but all bool data.

@dclaux dclaux mentioned this issue Jul 10, 2020
Merged
@shalinijoshi19 shalinijoshi19 added this to the 1.3 Schema Refresh milestone Aug 4, 2020
@ghost
Copy link

ghost commented Aug 6, 2020

🎉AdaptiveCards@2020.07 has been released which fixes this issue.:tada:

Handy links:

@microsoft microsoft deleted a comment Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Templating Bug Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
None yet
Milestone
1.3 Schema Refresh
2 participants
@IntranetFactory @shalinijoshi19