Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Icon is placed above title even if all actions don't contain icons #3361

Closed
RebeccaAnne opened this issue Aug 21, 2019 · 3 comments

Comments

@RebeccaAnne
Copy link
Contributor

RebeccaAnne commented Aug 21, 2019

Platform

JavaScript

Details

Using the IconsInSomeActions.json sample.

With actions host config set as follows:

	"actions": {
		"actionsOrientation": "horizontal",
		"iconPlacement": "aboveTitle"
	}

The icon placement should be left of title. From #389:
If iconUrl is null on ANY action within a set, the iconPlacement SHOULD BE leftOfTitle to ensure buttons are all the same height.

Expected (from UWP renderer):
image

Actual:
image

@dclaux
Copy link
Member

dclaux commented Aug 26, 2019

This behavior was added to the spec by @matthidinger after the spec was approved and after I was done with my implementation. It was never discussed, at least not as far as I can recall.

@ghost
Copy link

ghost commented Nov 29, 2019

This issue has been automatically marked as stale because it has not had any activity for 5 days.

@ghost ghost added the no-recent-activity label Nov 29, 2019
@ghost
Copy link

ghost commented Dec 6, 2019

This issue has been automatically marked as stale because it has not had any activity for 5 days.

@RebeccaAnne RebeccaAnne added this to the Backlog milestone Jul 27, 2020
@RebeccaAnne RebeccaAnne removed this from the Backlog milestone May 6, 2021
@jonmill jonmill removed the BugBash label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants