Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DiskSpaceMetrics to i.m.core.instrument.binder.system #2750

Closed
wilkinsona opened this issue Aug 16, 2021 · 2 comments
Closed

Move DiskSpaceMetrics to i.m.core.instrument.binder.system #2750

wilkinsona opened this issue Aug 16, 2021 · 2 comments
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module release notes Noteworthy change to call out in the release notes
Milestone
1.8.0-M3

Comments

@wilkinsona
Copy link
Contributor

Please describe the feature request.
DiskSpaceMetrics is currently packaged in io.micrometer.core.instrument.binder.jvm alongside various JVM-specific metrics classes such as ClassLoaderMetrics. I'd like to propose that io.micrometer.core.instrument.binder.jvm.DiskSpacveMEtrics is deprecated with a replacement being introduced in io.micrometer.core.instrument.binder.system alongside FileDescriptorMetrics.

Rationale
Disk space metrics are not JVM-specific so I don't think DiskSpaceMetrics belongs in the binder.jvm package. Additionally, they're closely related to file descriptor metrics so I think it makes sense to package them alongside FileDescriptorMetrics.

Additional context
spring-projects/spring-boot#27688
@wilkinsona wilkinsona added the enhancement A general enhancement label Aug 16, 2021
@wilkinsona wilkinsona mentioned this issue Aug 16, 2021
Closed
@shakuzen shakuzen added this to the 1.8 tentative milestone Aug 17, 2021
@shakuzen shakuzen added module: micrometer-core An issue that is related to our core module release notes Noteworthy change to call out in the release notes labels Aug 17, 2021
@shakuzen shakuzen modified the milestones: 1.8 tentative, 1.8.0-M3 Aug 17, 2021
@wilkinsona
Copy link
Contributor Author

Thanks, Tommy. Should the new class be @since 1.8.0? It’s currently 1.1.0.

@shakuzen
Copy link
Member

Good catch. I've removed the @Incubating annotation on the new class and added a @since 1.8.0 JavaDoc in cf7e540

@vgarmash vgarmash mentioned this issue Dec 30, 2021
Closed
@shakuzen shakuzen mentioned this issue Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module release notes Noteworthy change to call out in the release notes
Projects
None yet
Milestone
1.8.0-M3
Development

No branches or pull requests
2 participants
@wilkinsona @shakuzen