Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remark GFM does not parse URLs end with _ properly #11

Closed
4 tasks done
fourdim opened this issue Sep 8, 2024 · 2 comments
Closed
4 tasks done

remark GFM does not parse URLs end with _ properly #11

fourdim opened this issue Sep 8, 2024 · 2 comments
Labels
🙋 no/question This does not need any changes 👎 phase/no Post cannot or will not be acted on

Comments

@fourdim
Copy link

fourdim commented Sep 8, 2024

Initial checklist

Affected packages and versions

remark-gfm@4.0.0

Link to runnable example

https://stackblitz.com/edit/github-cbrfbi?file=src%2Fmain.ts

Steps to reproduce

Let remark GFM parse following markdown:

https://example.com/MuawcBMT1Mzvoar09-_66?mode=page&blockIds=rL2_GXbtLU2SsJVfCSmh_

Expected behavior

URL should be parsed to

<https://example.com/MuawcBMT1Mzvoar09-_66?mode=page&blockIds=rL2_GXbtLU2SsJVfCSmh_>

Actual behavior

URL is parsed to

<https://example.com/MuawcBMT1Mzvoar09-_66?mode=page&blockIds=rL2_GXbtLU2SsJVfCSmh>\_

Runtime

Node v16

Package manager

pnpm

OS

Linux

Build and bundle tools

Vite

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 8, 2024
@ChristianMurphy
Copy link
Member

Welcome @fourdim! 👋

That is the expected behavior.
This library matches GitHub, GitHub doesn't include the underscore.
See your example as parsed on GitHub below.

https://example.com/MuawcBMT1Mzvoar09-_66?mode=page&blockIds=rL2_GXbtLU2SsJVfCSmh_

@ChristianMurphy ChristianMurphy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2024
@ChristianMurphy ChristianMurphy added the 🙋 no/question This does not need any changes label Sep 8, 2024

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 no/question This does not need any changes 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants