[WIP] CSS resets #94
Closed
[WIP] CSS resets #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kikobeats
reviewed
Mar 25, 2018
| @@ -7,7 +7,7 @@ import { Content } from './CardContent' | |||
| import { media } from '../../utils' | |||
|
|
|||
| const EmptyImage = CardImage.extend` | |||
| ${emptyStateImageAnimation} | |||
| ${emptyStateImageAnimation}; | |||
There was a problem hiding this comment.
is the semicolon necessary? 🤔
Kikobeats
reviewed
Mar 25, 2018
| <NanoClamp className={className} lines={lines} text={children} is='p' /> | ||
| ) | ||
|
|
||
| const CardText = styled(Clamp)` | ||
| &&& { | ||
| font-family: inherit; | ||
| font-size: inherit; |
There was a problem hiding this comment.
are this inherit styles resets?
Kikobeats
reviewed
Mar 25, 2018
| border-color: #E1E8ED; | ||
| background: #fff; | ||
| border: 1px solid #e1e8ed; | ||
| margin: 0; |
Kikobeats
reviewed
Mar 25, 2018
| background-color: inherit; | ||
| ` | ||
|
|
||
| export const sizeReset = css` |
There was a problem hiding this comment.
I was thinking more in a file that content reset per each component, for example:
export const cardDescription = css`
text-decoration: none;
`Then when you load the specific reset style into the component is easy to determinate what style are part of the component and what are part of the reset:
// resets
${reset.cardDescription};
// specific styles
font-size: 14px;
flex-grow: 2;
margin: auto 0;
line-height: 18px;
${({cardSize}) => !isLarge(cardSize) && mobileDescriptionStyle};
Kikobeats
reviewed
Mar 25, 2018
Kikobeats
reviewed
Mar 25, 2018
| &:active, | ||
| &:hover { | ||
| outline: 0; | ||
| * { |
|
Do you think we still need that? The main reset styles are related with vanilla bundle and we added a recipe into doc to handle it properly Feeling that this is enough |
Kikobeats
force-pushed
the
master
branch
3 times, most recently
from
86f490e to
23b5dfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #92