Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linter warnings #296

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: linter warnings #296

merged 1 commit into from
Mar 15, 2023

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Jan 8, 2023

These changes are motivated by Next.js linter:

$ npx next lint

./src/index.js
101:6  Warning: React Hook useCallback has missing dependencies: 'apiUrlProps', 'fetchData', and 'mergeData'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps
101:38  Warning: React Hook useCallback has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked.  react-hooks/exhaustive-deps
156:5  Warning: React Hook useCallback has a missing dependency: 'updateState'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
159:3  Warning: React Hook useEffect has a missing dependency: 'toFetchData'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps

Related: https://github.com/microlinkhq/sdk/pull/297/files

@Kikobeats Kikobeats requested a review from breadadams January 8, 2023 11:00
@vercel
Copy link

vercel bot commented Jan 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sdk-hover-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 8, 2023 at 11:03AM (UTC)
sdk-hover-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 8, 2023 at 11:03AM (UTC)
sdk-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 8, 2023 at 11:03AM (UTC)
sdk-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 8, 2023 at 11:03AM (UTC)

@Kikobeats
Copy link
Member Author

@breadadams can you please take a look? I don't want to break nothing 😬

Copy link
Member

@breadadams breadadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Kikobeats Kikobeats merged commit 4222c9c into master Mar 15, 2023
@Kikobeats Kikobeats deleted the warnings branch March 15, 2023 10:43
@Kikobeats Kikobeats mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants