From 817da8157af5200f0558558518c576d2b1a8ecab Mon Sep 17 00:00:00 2001 From: Christopher Roy Bratusek Date: Wed, 23 Sep 2020 12:47:56 +0200 Subject: [PATCH 1/7] Separate launcher icon from main activity, so it can be disabled without breaking microG functionality. - Think of launchers that can't hide apps, so you need to disable the launcher activity in order to hide it. - Also useful when microG is embedded inside System Settings, and you want to disable the launcher icon. - Could in theory be used in the future for a feature "hide app icon" inside microG settings itself --- .../src/main/AndroidManifest.xml | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/play-services-core/src/main/AndroidManifest.xml b/play-services-core/src/main/AndroidManifest.xml index d230595417..7f2ca4488f 100644 --- a/play-services-core/src/main/AndroidManifest.xml +++ b/play-services-core/src/main/AndroidManifest.xml @@ -441,10 +441,8 @@ + android:exported="true" + android:process=":ui"> @@ -466,6 +464,7 @@ + + + + + + + + Date: Wed, 23 Sep 2020 12:56:18 +0200 Subject: [PATCH 2/7] Fix icon being not displayed on some devices with android 6, 7 and 7.1 (SDK 23,24,25) - correct category for System Settings embedding --- .../src/main/AndroidManifest.xml | 30 ++++++++++++++++--- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/play-services-core/src/main/AndroidManifest.xml b/play-services-core/src/main/AndroidManifest.xml index 7f2ca4488f..7a05f492a3 100644 --- a/play-services-core/src/main/AndroidManifest.xml +++ b/play-services-core/src/main/AndroidManifest.xml @@ -438,7 +438,7 @@ - + - + + + + + + + + + + + + android:value="com.android.settings.category.ia.homepage"/> @@ -485,7 +507,7 @@ android:resource="@string/gms_settings_summary" /> - + Date: Wed, 23 Sep 2020 13:05:02 +0200 Subject: [PATCH 3/7] improve icon for SDK up to 27 (via @Vavun), new vector icon for SDK 28+ (via @ghost) --- .../microg_light_color_24.xml | 16 +++++++----- .../microg_light_color_24.xml | 26 +++++++++++++++++++ 2 files changed, 35 insertions(+), 7 deletions(-) create mode 100644 play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml diff --git a/play-services-core/src/main/res/drawable-anydpi-v21/microg_light_color_24.xml b/play-services-core/src/main/res/drawable-anydpi-v21/microg_light_color_24.xml index 5d62e2e41e..0867792162 100644 --- a/play-services-core/src/main/res/drawable-anydpi-v21/microg_light_color_24.xml +++ b/play-services-core/src/main/res/drawable-anydpi-v21/microg_light_color_24.xml @@ -1,9 +1,11 @@ - + + + - + android:fillColor="#ffffffff" + android:pathData="M14.5335,0.0569535 L9.43985,0.0705542 C9.24288,0.102156,9.0985,0.18001,9.06273,0.352909 L8.55771,3.75569 C7.70454,4.01856,7.0852,4.47885,6.46902,4.94163 L3.48987,3.74936 C3.23326,3.67936,2.95937,3.47486,2.64004,3.95331 L0.0871706,8.21668 C0.0372893,8.41036,0.0580599,8.56989,0.145272,8.69686 L2.93012,10.8425 C2.83047,11.6279,2.86713,12.4355,2.90092,13.2426 L0.23227,15.219 C0.005066,15.4246,0.050044,15.7049,0.087127,15.8119 L2.78493,20.2165 C2.89848,20.3411,3.04458,20.3919,3.22668,20.3608 L6.49813,19.1434 C7.12487,19.6363,7.79275,20.0492,8.52873,20.3294 L8.99269,23.3505 C9.11365,23.56,9.09564,23.8073,9.4858,23.9434 L14.6784,23.9434 C14.8701,23.8649,15.0801,23.8217,15.1137,23.4353 L15.5776,20.2729 C16.4832,19.9372,17.01,19.5277,17.6663,19.1435 L20.7121,20.3576 C21.1885,20.4803,21.2695,20.2522,21.3504,20.16 L23.8741,15.8401 C23.9395,15.7104,23.9625,15.4495,23.787,15.2191 L21.1762,13.2708 C21.1953,12.4738,21.2347,11.6899,21.1762,10.8426 L23.874,8.72511 C23.996,8.49886,23.9302,8.24834,23.874,8.10387 L21.3214,3.92514 C21.1924,3.70382,20.9206,3.64557,20.7701,3.67097 L17.6082,4.94163 C16.8967,4.38465,16.2039,3.98905,15.5197,3.67097 L14.9974,0.395711 C14.9027,0.136848,14.7173,0.0991057,14.5334,0.0570135 Z M11.8718,5.62811 C13.7255,5.60431,15.517,6.32771,16.5932,7.54186 L14.7953,9.4995 C13.2639,8.11395,9.57199,7.53593,8.30443,11.1012 C7.82376,12.9227,8.54727,14.4138,10.0518,15.2852 C11.6506,16.1862,14.0977,15.4204,14.7343,14.7492 L16.6846,16.6771 C15.8496,17.3442,12.7132,19.81,8.67011,17.6858 C6.61824,16.5517,4.69843,14.6267,5.53146,10.4485 C6.00671,8.8177,7.06262,7.50059,8.60931,6.53345 C9.62512,5.92563,10.7596,5.64239,11.8718,5.62811 Z" /> diff --git a/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml b/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml new file mode 100644 index 0000000000..136d2dad86 --- /dev/null +++ b/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml @@ -0,0 +1,26 @@ + + + + + + + + + + + + + + From 6699b45d3cfee1e01838b845ac4aab4c92a49b7a Mon Sep 17 00:00:00 2001 From: Christopher Roy Bratusek Date: Wed, 23 Sep 2020 13:16:12 +0200 Subject: [PATCH 4/7] clean-up activity aliases for System Settings integration --- gradle.properties | 1 + play-services-core/src/main/AndroidManifest.xml | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/gradle.properties b/gradle.properties index 5bac8ac504..05514126b2 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1 +1,2 @@ android.useAndroidX=true +org.gradle.jvmargs=-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError diff --git a/play-services-core/src/main/AndroidManifest.xml b/play-services-core/src/main/AndroidManifest.xml index 7a05f492a3..512489253e 100644 --- a/play-services-core/src/main/AndroidManifest.xml +++ b/play-services-core/src/main/AndroidManifest.xml @@ -469,7 +469,6 @@ android:name="org.microg.gms.ui.SettingsActivityLink" android:icon="@drawable/microg_light_color_24" android:label="@string/gms_settings_name" - android:process=":ui" android:targetActivity="org.microg.gms.ui.SettingsActivity"> @@ -490,8 +489,7 @@ android:name="org.microg.gms.ui.SettingsActivityIALink" android:targetActivity="org.microg.gms.ui.SettingsActivity" android:icon="@drawable/microg_light_color_24" - android:label="@string/gms_settings_name" - android:theme="@style/Theme.AppCompat.Settings.Dashboard"> + android:label="@string/gms_settings_name"> From 8d2fda99e93d19ad9dd4e5477488bb59b0c3c511 Mon Sep 17 00:00:00 2001 From: Christopher Roy Bratusek Date: Wed, 23 Sep 2020 14:14:07 +0200 Subject: [PATCH 5/7] Don't show two launcher icons, improve System Settings integration on SDK 28+ --- .../src/main/AndroidManifest.xml | 4 --- .../microg_light_color_24.xml | 34 +++++-------------- 2 files changed, 9 insertions(+), 29 deletions(-) diff --git a/play-services-core/src/main/AndroidManifest.xml b/play-services-core/src/main/AndroidManifest.xml index 512489253e..3d1a274b91 100644 --- a/play-services-core/src/main/AndroidManifest.xml +++ b/play-services-core/src/main/AndroidManifest.xml @@ -443,10 +443,6 @@ android:name="org.microg.gms.ui.SettingsActivity" android:exported="true" android:process=":ui"> - - - - diff --git a/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml b/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml index 136d2dad86..027d5f88db 100644 --- a/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml +++ b/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml @@ -1,26 +1,10 @@ - - - - - - - - - - - - - + + + From 29cc170a1856c42319185a40c6623337efc20236 Mon Sep 17 00:00:00 2001 From: Christopher Roy Bratusek Date: Wed, 23 Sep 2020 14:39:25 +0200 Subject: [PATCH 6/7] drop duplicated icon --- .../res/drawable-anydpi-v28/microg_light_color_24.xml | 10 ---------- 1 file changed, 10 deletions(-) delete mode 100644 play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml diff --git a/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml b/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml deleted file mode 100644 index 027d5f88db..0000000000 --- a/play-services-core/src/main/res/drawable-anydpi-v28/microg_light_color_24.xml +++ /dev/null @@ -1,10 +0,0 @@ - - - - From 1c070366c530ae6eabb0e0299e7a261b4a4c9eb6 Mon Sep 17 00:00:00 2001 From: Christopher Roy Bratusek Date: Wed, 23 Sep 2020 15:12:02 +0200 Subject: [PATCH 7/7] fix for Android Q / android.permissions.ACCESS_BACKGROUND_LOCATION selfcheck --- play-services-core/src/main/AndroidManifest.xml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/play-services-core/src/main/AndroidManifest.xml b/play-services-core/src/main/AndroidManifest.xml index 3d1a274b91..bfe0ccd4a0 100644 --- a/play-services-core/src/main/AndroidManifest.xml +++ b/play-services-core/src/main/AndroidManifest.xml @@ -441,8 +441,7 @@ + android:exported="true"> @@ -465,7 +464,8 @@ android:name="org.microg.gms.ui.SettingsActivityLink" android:icon="@drawable/microg_light_color_24" android:label="@string/gms_settings_name" - android:targetActivity="org.microg.gms.ui.SettingsActivity"> + android:targetActivity="org.microg.gms.ui.SettingsActivity" + android:process=":ui"> @@ -485,7 +485,8 @@ android:name="org.microg.gms.ui.SettingsActivityIALink" android:targetActivity="org.microg.gms.ui.SettingsActivity" android:icon="@drawable/microg_light_color_24" - android:label="@string/gms_settings_name"> + android:label="@string/gms_settings_name" + android:process=":ui">