Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters not working in Iron through cli #195

Closed
rosterloh opened this issue Jun 6, 2023 · 5 comments
Closed

Parameters not working in Iron through cli #195

rosterloh opened this issue Jun 6, 2023 · 5 comments

Comments

@rosterloh
Copy link

Describe the bug
Using get|set|dump from the ros2 cli fails with Wait for service timed out waiting for parameter services for node /micro_ros_node. If you attempt to get or set parameters in code this works successfully.

To Reproduce
Steps to reproduce the behaviour:

  1. Create micro-ROS application with parameter server like this
  2. Connect the agent
  3. Run ros2 param dump esp32_param_node
  4. See error Wait for service timed out waiting for parameter services for node /esp32_param_node

Expected behaviour
ros2 param cli commands work as expected the same as non micro-ROS nodes

System information (please complete the following information):

  • OS: Ubuntu 22.04
  • ROS 2 Iron
  • Version 4.0.3
@pablogs9
Copy link
Member

pablogs9 commented Jun 7, 2023

Hey @rosterloh, we are currently releasing and testing Iron for micro-ROS, the official release is not already out.

CC: @Acuadros95 PTAL

@rosterloh
Copy link
Author

@pablogs9 I completely understand. I just saw you were working on it so I thought I'd bring it up while you were busy. I'd happily help test or work on anything for you if it helps.

@Acuadros95
Copy link
Contributor

Acuadros95 commented Jun 8, 2023

We were missing a parameter service on the micro-ROS client side, that is the reason for the Wait for service timed out waiting for parameter services message.

@rosterloh Thanks for checking this! This PR will solve the issue: ros2/rclc#354

@rosterloh
Copy link
Author

Amazing thanks @Acuadros95!

@Acuadros95
Copy link
Contributor

Closing as ros2/rclc#354 is merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants