Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Time for pointStart #265

Open
ghost opened this issue Jan 18, 2022 · 0 comments
Open

Support Time for pointStart #265

ghost opened this issue Jan 18, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Jan 18, 2022

At the moment it is not possible to set any point in time for pointStart. It always removes the time information. This PR would allow using a Time object.

Remarks:

  • There was one test that uses an integer for pointStart (and a wrong value for pointInterval). Integers are not supported. I changed that test.
  • Some tests on master did not work locally. It seems there is a problem with Webrat and RSpec
Failed examples:

rspec ./spec/lazy_high_charts_spec.rb:38 # HighChartsHelper layout_helper should return a div with an id of high_chart object
rspec ./spec/lazy_high_charts_spec.rb:42 # HighChartsHelper layout_helper should return a script
rspec ./spec/lazy_high_charts_spec.rb:49 # HighChartsHelper high_chart_globals should return a script
rspec ./spec/lazy_high_charts_spec.rb:62 # HighChartsHelper high_chart_graph ready function should be a javascript script
rspec ./spec/lazy_high_charts_spec.rb:67 # HighChartsHelper high_chart_graph ready function should assign to the onload event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants