Update flake8 and mypy stuff #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "inner": flag, | ||
| } | ||
| option_spec = _DoxygenContentBlockDirective.option_spec.copy() | ||
| option_spec.update({"inner": flag}) |
There was a problem hiding this comment.
Out of interest, why do you prefer this formulation? Does it have an objective benefit or just preferred style?
There was a problem hiding this comment.
It is just a style choice, to be consistent with the equivalent cases I have seen in Sphinx to more quickly spot what is going on.
michaeljones
approved these changes
Jan 21, 2022
|
@jakobandersen - please merge when you're happy with it :) |
- Remove noqa comments - Switch comment-based type annotation to variable type hints - Make mypy warn about redundant things - General mypy fixes
jakobandersen
force-pushed
the
lint_update
branch
from
fa27f60
to
ba775ec
Compare
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#noqacommentsThere is still one error left: