Fix sys.path adjustment in doc config #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaeljones This seems fine to me, any reason it's not merged yet assuming you have confirmed it works? |
|
After this, is the |
It seems that CI already changes the PYTHONPATH to adjust for this but this allows us to run 'make html' in either the root or 'documentation' and have it work as it used to.
Hoping that the adjustment to the sphinx conf file is sufficient.
michaeljones
force-pushed
the
fix-sys-path
branch
from
a222452
to
287113f
Compare
|
I've rebased & adjust the test file to remove the PYTHONPATH manipulation to see if that still works. I think I've been used to waiting for approvals on PRs from work for a while now and now I don't know how needs to (if anyone) approve such things. I will probably relax with time and start merging things that seem safe without waiting so long :) |
|
Seems to have passed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that CI already changes the PYTHONPATH to adjust for this but
this allows us to run 'make html' in either the root or 'documentation'
and have it work as it used to.