Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale six dep #682

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Remove stale six dep #682

merged 1 commit into from
Apr 23, 2021

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Apr 23, 2021

The use of six was removed entirely but a dependency on it was left
in setup.py. Remove it.

@mgorny
Remove stale six dep
6f30a85 
The use of six was removed entirely but a dependency on it was left
in setup.py.  Remove it.
@vermeeren vermeeren self-requested a review April 23, 2021 11:22
@vermeeren vermeeren self-assigned this Apr 23, 2021
@vermeeren vermeeren added bug Problem in existing code packaging Requirements, setup.py, etc labels Apr 23, 2021
vermeeren
vermeeren approved these changes Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgorny Yeah I indeed missed this, forgot to do grep -rIn I guess. Thanks for the fix!

michaeljones pushed a commit that referenced this pull request Apr 23, 2021
@vermeeren
changelog: update for #682
31edefc
@michaeljones michaeljones merged commit d477b5a into breathe-doc:master Apr 23, 2021
@mgorny
Copy link
Contributor Author

mgorny commented Apr 23, 2021

Thanks!

@mgorny mgorny deleted the six-dep branch April 23, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vermeeren vermeeren vermeeren approved these changes

Assignees

@vermeeren vermeeren

Labels
bug Problem in existing code packaging Requirements, setup.py, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgorny @vermeeren @michaeljones