Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing getter and setter for csharp #661

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Add missing getter and setter for csharp #661

merged 1 commit into from
Mar 29, 2021

Conversation

xuhongxu96
Copy link
Contributor

@xuhongxu96 xuhongxu96 commented Mar 18, 2021 •
edited
Loading

Fix #660

  • Add missing getter and setter for csharp
  • Remove spaces in typename to handle the generic type correctly:
    image
    -- to -->
    image

@vermeeren vermeeren self-requested a review March 29, 2021 01:53
@vermeeren vermeeren self-assigned this Mar 29, 2021
@vermeeren vermeeren added code Source code enhancement Improvements, additions (also cosmetics) labels Mar 29, 2021
vermeeren
vermeeren approved these changes Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuhongxu96 Sorry for the wait. Changes look good to me, thanks for the patch! Will rebase and then merge.

vermeeren
vermeeren requested changes Mar 29, 2021
View reviewed changes
breathe/renderer/sphinxrenderer.py Outdated Show resolved Hide resolved
vermeeren
vermeeren approved these changes Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuhongxu96 Thanks for the quick fix!

michaeljones pushed a commit that referenced this pull request Mar 29, 2021
@vermeeren
changelog: update for #661
bc00cfc
@michaeljones michaeljones merged commit 4b739a2 into breathe-doc:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vermeeren vermeeren vermeeren approved these changes

Assignees

@vermeeren vermeeren

Labels
code Source code enhancement Improvements, additions (also cosmetics)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Getter and Setter in C# Property
3 participants
@xuhongxu96 @vermeeren @michaeljones