Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render pages content in order #651

Merged

Conversation

gmarull
Copy link
Contributor

@gmarull gmarull commented Mar 3, 2021

When rendering Doxygen pages one expects content to appear in the
written order. As of today para sections content was grouped
separately depending on its type, causing out-of-order content in some
pages.

Fixes #648

@gmarull
Copy link
Contributor Author

gmarull commented Mar 3, 2021

cc: @utzig

@gmarull gmarull force-pushed the feature/render-pages-content-in-order branch from ed79525 to 6768147 Compare March 3, 2021 15:52
When rendering Doxygen pages one expects content to appear in the
written order. As of today `para` sections content was grouped
separately depending on its type, causing out-of-order content in some
pages.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull gmarull force-pushed the feature/render-pages-content-in-order branch from 6768147 to a46be23 Compare March 3, 2021 15:53
Copy link

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmarull
Copy link
Contributor Author

gmarull commented Mar 8, 2021

@utzig @vermeeren can you review? thanks

@gmarull
Copy link
Contributor Author

gmarull commented Mar 15, 2021

@michaeljones can you review? thanks

Copy link
Contributor

@utzig utzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vermeeren vermeeren self-requested a review March 29, 2021 00:46
@vermeeren vermeeren self-assigned this Mar 29, 2021
@vermeeren vermeeren added bug Problem in existing code code Source code labels Mar 29, 2021
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmarull Looks good, thanks!

michaeljones pushed a commit that referenced this pull request Mar 29, 2021
@michaeljones michaeljones merged commit 52fbb88 into breathe-doc:master Mar 29, 2021
@gmarull gmarull deleted the feature/render-pages-content-in-order branch March 29, 2021 09:41
@gmarull
Copy link
Contributor Author

gmarull commented Mar 29, 2021

@vermeeren @michaeljones would you mind creating a new release? Thanks!

@vermeeren
Copy link
Collaborator

@gmarull I intend on making a release after #642 is handled, which should be within a day or two based upon past experiences.

@vermeeren
Copy link
Collaborator

@gmarull v4.28.0 is now released containing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem in existing code code Source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of order rendering in pages
5 participants