Fix anonymous struct/union usage in C domain #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utzig
force-pushed
the
fix-c-domain-anon
branch
from
2988530
to
25056e2
Compare
Sphinx's C domain parser expects '.' to be used to separate nested names. This is currently broken when there are anonymous structs/unions in the source, where the Doxygen XML provides some nested name with "::@" in it, which fails to be parsed properly. This commit adds a check and does the proper substitution before sending data back to the domain parser. Signed-off-by: Fabio Utzig <fabio.utzig@nordicsemi.no>
|
Nice catch. Looks good to me. |
vermeeren
approved these changes
Sep 26, 2020
vermeeren
added a commit
that referenced
this pull request
Sep 26, 2020
|
@utzig Thanks again, do you want this to be released asap? |
Would be very nice of you, I am quite sure this is the last Breathe bug I have, so hopefully no longer annoying you! :-) |
|
@utzig Just released v4.22.1 in that case, and the patches are definitely appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx's C domain parser expects '.' to be used to separate nested names. This is currently broken when there are anonymous structs/unions in the source, where the Doxygen XML provides some nested name with "::@" in it, which fails to be parsed properly. This commit adds a check and does the proper substitution before sending data back to the domain parser.