Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breathe_show_enumvalue_initializer option #581

Merged

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Sep 16, 2020

No description provided.

@yamt
Copy link
Contributor Author

yamt commented Sep 16, 2020

this PR implements #578

@utzig
Copy link
Contributor

utzig commented Sep 16, 2020

You should probably squash your commits.

Default to false, following breathe_show_define_initializer,
as suggested by @vermeeren.
@yamt yamt force-pushed the breathe_show_enumvalue_initializer branch from ee80059 to 00994e6 Compare September 16, 2020 00:28
@yamt
Copy link
Contributor Author

yamt commented Sep 16, 2020

@utzig ok. done

@vermeeren vermeeren self-assigned this Sep 17, 2020
@vermeeren vermeeren self-requested a review September 17, 2020 14:21
@vermeeren vermeeren added code Source code enhancement Improvements, additions (also cosmetics) labels Sep 17, 2020
@vermeeren vermeeren linked an issue Sep 17, 2020 that may be closed by this pull request
@vermeeren vermeeren merged commit 87fc859 into breathe-doc:master Sep 17, 2020
@vermeeren
Copy link
Collaborator

@yamt Thanks for the patch, is it desired to have a new Breathe release for this?

@yamt
Copy link
Contributor Author

yamt commented Sep 17, 2020

@yamt yes, as we are using a released version to render our document. not urgent at all though.

@vermeeren
Copy link
Collaborator

@yamt fyi I have released v4.22.0 just now containing this patch.

@yamt
Copy link
Contributor Author

yamt commented Sep 19, 2020

@vermeeren thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Source code enhancement Improvements, additions (also cosmetics)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breathe_show_enumvalue_initializer
3 participants