Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse breathe.__version__ in setup #572

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Reuse breathe.__version__ in setup #572

merged 1 commit into from
Aug 28, 2020

Conversation

utzig
Copy link
Contributor

@utzig utzig commented Aug 28, 2020

Avoid having to edit two files when updating for a new release.

@utzig
Reuse breathe.__version__ in setup
99c4859 
Avoid having to edit two files when updating for a new release.

Signed-off-by: Fabio Utzig <fabio.utzig@nordicsemi.no>
@vermeeren vermeeren self-assigned this Aug 28, 2020
vermeeren
vermeeren approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine and avoids the issue described in #553 by only importing the version, hopefully avoiding pulling in deps such as Sphinx.

@vermeeren vermeeren added the enhancement Improvements, additions (also cosmetics) label Aug 28, 2020
@vermeeren vermeeren merged commit aee8e19 into breathe-doc:master Aug 28, 2020
vermeeren added a commit that referenced this pull request Aug 28, 2020
@vermeeren
changelog: update for #571, #572, #573
67a3c4c
@utzig utzig deleted the setup-reuse-version branch August 31, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vermeeren vermeeren vermeeren approved these changes

Assignees

@vermeeren vermeeren

Labels
enhancement Improvements, additions (also cosmetics)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utzig @vermeeren