Fix crash when visiting typedef

[utzig]

When using the @typedef <name> doxygen command, the generated XML does not have a proper definition, "using ..." or "typedef ..."; this used to work with versions <= 4.16.0 by assuming everything as a typedef. To fix the issue, check if "using " is found, otherwise fall back to considering that "typedef " was used. If not "typedef " is found in the definition, print a warning.

Fixes #534

[utzig]

I know this has issues with using ... but I don't see an obvious way to handle it. Also I am not sure about adding a warning at all; also any particular reason why the Sphinx logger isn't used here?

[vermeeren]

I did mess around a bit with something similar a few weeks ago doing some testing, based upon #534 (comment) and of course other comments on the issue, but somehow I forgot to finalise things and turn it into a PR. Thanks for creating one.

Edit:

Also I am not sure about adding a warning at all; also any particular reason why the Sphinx logger isn't used here?

I suspect very old code / legacy stuff, I have been maintaining since 2018 but there is still a lot of voodoo going on that I can't wrap my head around (yet).

[utzig]

I did mess around a bit with something similar a few weeks ago doing some testing, based upon #534 (comment) and of course other comments on the issue, but somehow I forgot to finalise things and turn it into a PR. Thanks for creating one.

I was expecting someone to send it, but got tired of waiting! :-)

I suspect very old code / legacy stuff, I have been maintaining since 2018 but there is still a lot of voodoo going on that I can't wrap my head around (yet).

Well, we have 'Sphinx>=3.0,<3.2' as requirements, so it's OK to change those prints in sphinxrenderer.py to use the Sphinx logger then?

[vermeeren]

Well, we have 'Sphinx>=3.0,<3.2' as requirements, so it's OK to change those prints in sphinxrenderer.py to use the Sphinx logger then?

Yeah that's definitely fine, if I grep a bit it seems that it is already fixed properly for most occurrences of the word warning. Thanks!

[vermeeren]

@jakobandersen Could you also take a look just in case?

[jakobandersen]

Looks good to me.