Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #528

Merged
merged 18 commits into from
May 22, 2020
Merged

Refactoring #528

merged 18 commits into from
May 22, 2020

Conversation

jakobandersen
Copy link
Collaborator

While trying to figure out how things work together and fix an issue I got a little side-tracked, so:

  • Add type-checking via mypy to the Github CI (make type-check).
  • Add a lot of typing to much of the code.
    Notably not to the XML reading as it seems to be auto-generated.
  • Remove some factories and simplify the related code.
  • Simplify the initial setup code and make the core Sphinx application object directly available in more classes.
  • Shuffle a few things around for structuring.

@vermeeren vermeeren self-assigned this May 22, 2020
@vermeeren vermeeren self-requested a review May 22, 2020 21:19
@vermeeren
Copy link
Collaborator

Sorry for the long wait and thanks as always.

@vermeeren vermeeren merged commit eb9ff50 into breathe-doc:master May 22, 2020
vermeeren added a commit that referenced this pull request May 22, 2020
@jakobandersen jakobandersen deleted the refactoring branch May 23, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants