Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dep versions in readme, setup, requirements #419

Merged
merged 1 commit into from
Feb 11, 2019
Merged

update dep versions in readme, setup, requirements #419

merged 1 commit into from
Feb 11, 2019

Conversation

vermeeren
Copy link
Collaborator

closes #416

@vermeeren vermeeren added bug Problem in existing code code Source code labels Feb 9, 2019
@vermeeren vermeeren self-assigned this Feb 9, 2019
@t-b
Copy link
Contributor

t-b commented Feb 10, 2019

@melvinvermeeren

Using >= instead of == sounds like a good idea.

I think we should depend on sphinx 1.8.4 or later due to the recent bugfixes.

Are you really still using doxygen 1.8.4? This part of the readme and also the part about the xml errors in doxygen 1.5.1 seems more like of historic interest.

@vermeeren
Copy link
Collaborator Author

@t-b

It should also work (even if with bugs) with 1.8.0 though as the API is compatible, so I believe marking this as absolute minimum is better. In practice I do expect people that run the latest breathe to also run the latest sphinx for all the bugfixes.

As for the other deps, they are horribly outdated and breathe or sphinx might not even work with the versions mentioned. Doxygen 1.8.4 appears to be from 2013, Debian jessie (oldstable) has 1.8.8. We don't have any proper tests or CI with various python environments to properly validate minimum versions so I'm not sure what this should be changed too. Probably leave it as is until we get some bug report or proper validation going?

@t-b
Copy link
Contributor

t-b commented Feb 11, 2019

It should also work (even if with bugs) with 1.8.0 though as the API is compatible, so I believe marking this as absolute minimum is better. In practice I do expect people that run the latest breathe to also run the latest sphinx for all the bugfixes.

Okay, if this was taken into consideration, this sounds good as well.

Probably leave it as is until we get some bug report or proper validation going?

Yes let's leave it for now.

@vermeeren vermeeren merged commit 7b81f82 into master Feb 11, 2019
@vermeeren vermeeren deleted the 416 branch February 11, 2019 15:28
vermeeren added a commit that referenced this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem in existing code code Source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require a newer version of Sphinx
2 participants