Don't append separator for paragraph type. #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermeeren
added
bug
Another way to fix this is to include only text types, but there may be other types (enums?) that do need the separator. For now exclude only paragraph type. Closes #381.
vermeeren
force-pushed
the
381-paragraph-has-no-attribute-startswith
branch
from
bbdb870
to
63def4b
Compare
|
As for why we don't append separators. With reproduction project it would have put |
|
Two friends reviewed changes and approved. CI approves too. Merging for 4.9.1. |
vermeeren
added a commit
that referenced
this pull request
Jun 3, 2018
vermeeren
added a commit
that referenced
this pull request
Jun 4, 2018
…ute-startswith Don't append separator for paragraph type.
vermeeren
added a commit
that referenced
this pull request
Jun 4, 2018
vermeeren
added a commit
that referenced
this pull request
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another way to fix this is to include only text types, but there may
be other types (enums?) that do need the separator. For now exclude only
paragraph type.
Closes #381.