Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return parallel_{read,write}_safe true for sphinx #376

Merged
merged 1 commit into from
May 26, 2018

Conversation

vermeeren
Copy link
Collaborator

closes #141

on the few projects I have locally it works fine with this change
and calling sphinx with -j auto

I haven't examined all source code, this needs further testing

see #141

on the few projects I have locally it works fine with this change
and calling sphinx with -j auto

I haven't examined all source code, this needs further testing
@vermeeren
Copy link
Collaborator Author

I must admit that although I have done basic "logic checking" in my head and have run tests on several projects, including the very large zephyrproject-rtos/zephyr#6823, I cannot be 100% certain that all possibilities and edge cases will work.

Personally I think it is better to merge this now and perhaps deal with bug reports for edge cases later, especially because the issue has been open since end 2014.

@vermeeren vermeeren requested a review from Andne May 12, 2018 21:07
@SylvainCorlay
Copy link
Contributor

SylvainCorlay commented May 13, 2018

@michaeljones what do you think of @melvinvermeeren's proposal? (to merge and solve for hedge cases if we find some later)

I am travelling this week, but I can check this branch against the QuantStack projects when I am back.

@vermeeren vermeeren self-assigned this May 21, 2018
@vermeeren
Copy link
Collaborator Author

Once other open PRs are handled and I have done some issue tracker cleanup with perhaps minor fixes I intend on releasing the next version of Breathe. In case there are no approvals or objections on this PR I will most likely merge this before that release.

@vermeeren vermeeren added enhancement Improvements, additions (also cosmetics) code Source code labels May 21, 2018
@vermeeren vermeeren removed the request for review from Andne May 26, 2018 12:48
@vermeeren
Copy link
Collaborator Author

Will be releasing 4.8.0 in a bit. A bit over a third of the issues has been checked at this point. Merging this in time for 4.8.0.

@vermeeren vermeeren merged commit 822e8e7 into master May 26, 2018
@vermeeren vermeeren deleted the 141-warning-when-using-sphinx-j-option branch May 26, 2018 12:49
vermeeren added a commit that referenced this pull request May 26, 2018
vermeeren added a commit that referenced this pull request Jun 4, 2018
…nx-j-option

return parallel_{read,write}_safe true for sphinx
vermeeren added a commit that referenced this pull request Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Source code enhancement Improvements, additions (also cosmetics)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning when using Sphinx's -j option
2 participants