Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same problem from project euler #13

Closed
Grv-Singh opened this issue May 24, 2021 · 8 comments · Fixed by #14
Closed

Same problem from project euler #13

Grv-Singh opened this issue May 24, 2021 · 8 comments · Fixed by #14
Assignees
Labels
enhancement New feature or request

Comments

@Grv-Singh
Copy link

Each time a Problem is requested from Project euler, the same problem is populated with it's markdown file and python file, in my case it is stuck at problem 100
image

@michaelfromyeg
Copy link
Collaborator

Hey! You're definitely right, I think I set it up so that it only returns problem 100, since I was hacking things together for the hack-a-thon where this was first built.

...but seeing as I have some real users, I can fix this! I'll have a PR up for it shortly.

I'm thinking of two options:

  • Get a random Project Euler problem (i.e., it generates a number 1 through X)
  • Select a Project Euler problem (i.e., enter a number 1 through X)

Anything else I should add? Also, feel free to send any other feedback you have here: mdemar01@student.ubc.ca.

@michaelfromyeg michaelfromyeg self-assigned this May 25, 2021
@michaelfromyeg michaelfromyeg added the enhancement New feature or request label May 25, 2021
@michaelfromyeg michaelfromyeg linked a pull request May 27, 2021 that will close this issue
@Grv-Singh
Copy link
Author

Grv-Singh commented May 29, 2021

Hey! Yes, definitely the option one is the best way. Let's choose a random no. b/w 1 & 747. Although this number is dynamic.. it might go up or down. Better to have this number driven by the API as well.. Thanks for this extension sir.. it helps to solve project euler problems in a familiar environment.

@michaelfromyeg
Copy link
Collaborator

For sure, I think for now I'll use that 747 value as an upper-bound, and in the future will look to check it dynamically... somehow. Glad to hear you're enjoying this project. I should have the PR finished tonight, latest tomorrow.

@michaelfromyeg
Copy link
Collaborator

New version is published.

@Grv-Singh
Copy link
Author

Hey! thanks for the quick update. But you should know the random option is still not working.
image

@michaelfromyeg
Copy link
Collaborator

@Grv-Singh sorry about this -- just fixed it! There was a bug in the API URL the extension was creating, it's patched in 1.0.2.

@michaelfromyeg
Copy link
Collaborator

@Grv-Singh just want to follow-up and make sure this is fixed -- is it working for you okay now?

@Grv-Singh
Copy link
Author

@michaelfromyeg Indeed, it is working as expected. Many thanks for your quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants