You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I have observed that this amazing project utilizes the third-party libraries folly and fbthrift, managing them through vcpkg for package management on Windows. However, both folly and fbthrift are included as submodules. As of today, newer versions of folly and fbthrift (maintained by myself) are available in vcpkg, currently at version 2024.05.02 (with version 2024.05.06 awaiting review). Therefore, it is now feasible to manage these two dependencies using vcpkg.
The text was updated successfully, but these errors were encountered:
Hi and thanks for your effort! Coincidentally, I wrote this note just a few hours ago about why attempts to externalize folly / fbthrift are, at least for the time being, a bad idea.
So unfortunately, I won't be moving away from the submodules approach for now; not because I don't want to, but because it's currently not safe to do so. Other projects depending on folly / fbthrift may be lucky if they link the libraries statically and use the same compile flags that were used for building folly / fbthrift, but it can be hard to tell (and even harder to debug) if something is wrong.
Sorry for the bad news, but I've been there a few times now and won't try again unless there's an upstream effort to officially support at least static linking across different C++ standards.
Hello, I have observed that this amazing project utilizes the third-party libraries folly and fbthrift, managing them through vcpkg for package management on Windows. However, both folly and fbthrift are included as submodules. As of today, newer versions of folly and fbthrift (maintained by myself) are available in vcpkg, currently at version 2024.05.02 (with version 2024.05.06 awaiting review). Therefore, it is now feasible to manage these two dependencies using vcpkg.
The text was updated successfully, but these errors were encountered: