Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor fbthrift & folly using vcpkg #223

Closed
c8ef opened this issue May 7, 2024 · 2 comments
Closed

Vendor fbthrift & folly using vcpkg #223

c8ef opened this issue May 7, 2024 · 2 comments
Labels
wontfix This will not be worked on

Comments

@c8ef
Copy link

c8ef commented May 7, 2024

Hello, I have observed that this amazing project utilizes the third-party libraries folly and fbthrift, managing them through vcpkg for package management on Windows. However, both folly and fbthrift are included as submodules. As of today, newer versions of folly and fbthrift (maintained by myself) are available in vcpkg, currently at version 2024.05.02 (with version 2024.05.06 awaiting review). Therefore, it is now feasible to manage these two dependencies using vcpkg.

@mhx mhx added the wontfix This will not be worked on label May 7, 2024
@mhx
Copy link
Owner

mhx commented May 7, 2024

Hi and thanks for your effort! Coincidentally, I wrote this note just a few hours ago about why attempts to externalize folly / fbthrift are, at least for the time being, a bad idea.

So unfortunately, I won't be moving away from the submodules approach for now; not because I don't want to, but because it's currently not safe to do so. Other projects depending on folly / fbthrift may be lucky if they link the libraries statically and use the same compile flags that were used for building folly / fbthrift, but it can be hard to tell (and even harder to debug) if something is wrong.

Sorry for the bad news, but I've been there a few times now and won't try again unless there's an upstream effort to officially support at least static linking across different C++ standards.

@mhx mhx closed this as completed May 7, 2024
@c8ef
Copy link
Author

c8ef commented May 7, 2024

Got it. Thanks for you explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants