Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to add MAX incoming connection from remote? #6

Open
wazerstar opened this issue Apr 8, 2022 · 5 comments
Open

Possible to add MAX incoming connection from remote? #6

wazerstar opened this issue Apr 8, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@wazerstar
Copy link

Hi I'm using this with the rate limit and its fantastic, however I checked to see if I could find any relation to allowing max active connection from a client/remote and did not succeed.

Would this be something you would consider adding to this or any other project in caddy?

@mholt
Copy link
Owner

mholt commented Apr 11, 2022

Difficult to say. Connection pooling is handled by the standard library. (As discussed on your forum topic).

It'd probably be much easier (and more practical) to limit the max number of active requests.

I'd be open to a proposal for this feature. It wouldn't be time-based, so that's a little interesting in terms of RL logic.

@wazerstar
Copy link
Author

Difficult to say. Connection pooling is handled by the standard library. (As discussed on your forum topic).

It'd probably be much easier (and more practical) to limit the max number of active requests.

I'd be open to a proposal for this feature. It wouldn't be time-based, so that's a little interesting in terms of RL logic.

With this case in here, this would actually be to limit client/remote not to use up all limited connections to the unit, in this case 4.

So yeah would be very cool to get as a feature :)

@mholt mholt added enhancement New feature or request help wanted Extra attention is needed labels Apr 11, 2022
@mholt
Copy link
Owner

mholt commented Apr 11, 2022

Ok; feel free to contribute then! Or anyone else who would like this. (Or I could be commissioned via sponsorship. I do have a backlog for a few weeks right now though.)

@wazerstar
Copy link
Author

Ok; feel free to contribute then! Or anyone else who would like this. (Or I could be commissioned via sponsorship. I do have a backlog for a few weeks right now though.)

Thanks what would commissioned typical be?

@mholt
Copy link
Owner

mholt commented Apr 25, 2022

@wazerstar Good question, that kind of depends on the project scope and requirements. Right now my understanding is that you need to limit the number of connections to 4 per client, but you don't care about counting requests; limiting connections instead of requests will be a little trickier and probably cost more. (I still think limiting requests will be more useful btw.)

If you email me with your specific technical requirements, matt at dyanim dotcom, I can give you an estimate. Sponsorship tiers are here: https://github.com/sponsors/mholt - and you can see that some tiers offer discounts on development work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants