-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete all locks button #357
Comments
After updating from 6.0.6 to 6.0.7 I feel there are fewer problems comparing with the previous version, but I keep seeing locks stuck in Redis. I think it is something related to scheduled + retry queues + failures. For example, we have a worker A which enqueue other workers B. These workers B can re-enqueue it selves to run again after 1min if they are in a pooling state, and sometimes these jobs never run again because there is a lock which was not released correctly by some previous job. In this case these are the keys which are not being deleted:
I think the lock is not being released correctly when the job fails and it is executed again by the retry queue. After the retry queue executes without error, I've noticed the jobs didn't run again (because they are locked). |
Hello @fabioperrella I have the same behaviour:
|
I'm seeing this same thing. |
+1 |
Also dealt with this. Had to go onto Redis and delete the keys myself before I was able to move on.
|
I'll make it happen sometime soon! |
Is your feature request related to a problem? Please describe.
I'm still experiencing locks and jobs that stops being scheduled.
I've updated the gem version to 6.0.7 but I'm still seeing the count of uniquejobs raising time after time.
I usually check with this:
redis-cli --scan --pattern 'uniquejobs:*' | wc -l
Describe the solution you'd like
I'm currently cleaning my environment performing a delete of all keys when the system is "quiet"
redis-cli --scan --pattern 'uniquejobs:*' | xargs redis-cli DEL
A "Delete all locks" button inside Sidekiq Unique UI section page would be a nice to have.
Describe alternatives you've considered
upgrade of sidekiq version - no luck
upgrade of sidekiq-unique-jobs - no luck
I'm planning to drop sidetiq definitely and use sidekiq-cron instead
Additional context
I'm using ruby 2.3.4 version on Ubuntu
My Gemfile:
Gemfile.lock extract
Thank you for your help.
The text was updated successfully, but these errors were encountered: