Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentError: sidekiq_unique_jobs/web breaks sidekiq Retries page #306

Closed
soundasleep opened this issue Jul 31, 2018 · 0 comments
Closed

Comments

@soundasleep
Copy link
Contributor

Describe the bug
If you add sidekiq_unique_jobs/web to routes.rb, the Retries page on Sidekiq no longer works. It crashes with the following trace:

wrong number of arguments (given 1, expected 2)

sidekiq-unique-jobs (6.0.0) lib/sidekiq_unique_jobs/web/helpers.rb:8:in `filtering'
(eval):12:in `_erb_retries'
sidekiq (5.1.3) lib/sidekiq/web/action.rb:85:in `_erb'
sidekiq (5.1.3) lib/sidekiq/web/action.rb:54:in `erb'
sidekiq (5.1.3) lib/sidekiq/web/application.rb:148:in `block in <class:WebApplication>'
sidekiq (5.1.3) lib/sidekiq/web/application.rb:266:in `instance_exec'
sidekiq (5.1.3) lib/sidekiq/web/application.rb:266:in `block in call'
sidekiq (5.1.3) lib/sidekiq/web/application.rb:262:in `catch'
sidekiq (5.1.3) lib/sidekiq/web/application.rb:262:in `call'

It looks like the filtering helper you define is already in use with sidekiq.

Expected behavior
The Retries page doesn't crash when using sidekiq_unique_jobs/web.

Additional context
Latest sidekiq (5.1.3)
Latest sidekiq_unique_jobs (6.0.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants