Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking with retries #289

Closed
florrain opened this issue Jul 14, 2018 · 4 comments
Closed

Locking with retries #289

florrain opened this issue Jul 14, 2018 · 4 comments

Comments

@florrain
Copy link

Hello,

The latest version does not seem to keep the lock after an exception is raised from a worker. Is that on purpose, and if so is there a way to keep the lock and release it only if the job has successfully run in a :until_executed lock type for example?

Thanks

@mhenrixon
Copy link
Owner

Just let me clarify, you are referring to the v6.0.0.rc5 version right @florrain? That is not how I intended it to work, it might be that my tests miss the case when the lock yields and an error is raised in the worker. I'll see if I can find out what is going on.

@mhenrixon
Copy link
Owner

Found the problem and will fix it and release a new gem version in half an hour or so.

@mhenrixon
Copy link
Owner

@florrain fixed in v6.0.0.rc6

@florrain
Copy link
Author

Thanks @mhenrixon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants