Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't enable testing with newer versions of sidekiq #175

Closed
Slania opened this issue Mar 23, 2016 · 2 comments
Closed

Can't enable testing with newer versions of sidekiq #175

Slania opened this issue Mar 23, 2016 · 2 comments
Labels
bug

Comments

@Slania
Copy link

Slania commented Mar 23, 2016

https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/lib/sidekiq_unique_jobs/testing/sidekiq_overrides.rb#L15

Couldn't understand the motivation behind that check, but with https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/testing.rb#L52, that will never proc.
@mhenrixon
Copy link
Owner

Sorry its taken so long. Seems to present itself frequently in the current master in similar but not identical ways. I'll get this fixed for the next release.

@mhenrixon
Copy link
Owner

https://github.com/mhenrixon/sidekiq-unique-jobs/releases/tag/v4.0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhenrixon @Slania