Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Complex Patterns Category #96

Closed
bbenetskyy opened this issue Jun 27, 2020 · 3 comments
Closed

Fix Complex Patterns Category #96

bbenetskyy opened this issue Jun 27, 2020 · 3 comments
Assignees
Labels
🕹️ playground Related to sample project, not the library 🍄 bug Something isn't working

Comments

@bbenetskyy
Copy link
Collaborator

In Playground App we have hidden Complex Patterns category with not supported for a moment CSS Code.

After #95 will be merged we should go and provide proper changes for gradients in Complex Patterns Category and add it into Playground database at Matadata.json and insert with name and slug into Categories.json file.

@bbenetskyy bbenetskyy added 🍄 bug Something isn't working 🕹️ playground Related to sample project, not the library labels Jun 27, 2020
@mgierlasinski
Copy link
Owner

mgierlasinski commented Jun 27, 2020

@bbenetskyy Without #95 you should be able to fix Gradient Parser for background-size in CSS, now we have:

{
    "slug": "b79936eb-215b-4d46-801d-800e7057bf3e",
    "stylesheet": "repeating-radial-gradient(...)52px 52px", // this is bad
    "tags": [ "complexpatterns" ]
  },

change to:

{
    "slug": "b79936eb-215b-4d46-801d-800e7057bf3e",
    "stylesheet": "repeating-radial-gradient(...)",
    "size": "52px 52px",
    "tags": [ "complexpatterns" ]
  },

Later, when we have #95, we can read "size".

@mgierlasinski
Copy link
Owner

@bbenetskyy Are there still issues with rendering after latest updates?

@bbenetskyy
Copy link
Collaborator Author

In the latest Playground DB this looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹️ playground Related to sample project, not the library 🍄 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants