Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radial gradient: CSS parser swallows first color #114

Closed
mgierlasinski opened this issue Sep 9, 2020 · 0 comments · Fixed by #123
Closed

Radial gradient: CSS parser swallows first color #114

mgierlasinski opened this issue Sep 9, 2020 · 0 comments · Fixed by #123
Assignees
@mgierlasinski
Labels
🍄 bug Something isn't working
Milestone
v1.2.0

Comments

@mgierlasinski
Copy link
Owner

With given css:

radial-gradient(red, green, blue)

Parser always tries to get gradient properties from first token (red in this case). Because it's not recognized as valid, it creates radial gradient with default properties and moves to next token (green), red is skipped and not added to color stops.
@mgierlasinski mgierlasinski added the 🍄 bug Something isn't working label Sep 9, 2020
@mgierlasinski mgierlasinski added this to the v1.2.0 milestone Sep 9, 2020
@mgierlasinski mgierlasinski self-assigned this Sep 9, 2020
@mgierlasinski mgierlasinski changed the title Radial gradient: CSS parser swallows first color step Radial gradient: CSS parser swallows first color Sep 9, 2020
@mgierlasinski mgierlasinski mentioned this issue Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgierlasinski mgierlasinski

Labels
🍄 bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Radial parser swallows first color mgierlasinski/MagicGradients
1 participant
@mgierlasinski