Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bikeshed: popup=popup is unusual #2

Closed
domenic opened this issue Feb 23, 2022 · 1 comment
Closed

Bikeshed: popup=popup is unusual #2

domenic opened this issue Feb 23, 2022 · 1 comment

Comments

@domenic
Copy link

domenic commented Feb 23, 2022

The x=x pattern in HTML is generally used as a way to allow XML serializations (i.e. "XHTML") to do boolean attributes. I.e. instead of the simple <div checked>, you'd do <div checked="checked">, because XML does not allow value-less attributes.

We should probably avoid using this pattern for a non-boolean attribute, as it will confuse people.

Ideas:

  • Rename the attribute. (E.g. toplayerbehavior=popup or toplayer=popup.)
  • Rename the value. (E.g. popup=default, popup=onlyone.)
  • Have no value, and just a state. (So you'd do <div popup> with no value to get this behavior.)

I imagine there's going to be a general bikeshedding fest on popup/hint/async, but I just wanted to note this as a relatively high-priority consideration in that bikeshed.

@mfreed7
Copy link
Owner

mfreed7 commented Mar 16, 2022

I've moved this issue to here: openui/open-ui#491

@mfreed7 mfreed7 closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants